Skip to content

test(BinaryFinder): Make sure the test is portable between systems #54914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Sep 5, 2025
Merged

test(BinaryFinder): Make sure the test is portable between systems #54914

provokateurin merged 1 commit into from
Sep 5, 2025

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Sep 5, 2025

The test is not very portable right now, because it assumes binaries are in certain places while they don't have to be there necessarily:

There were 2 failures:

1) Test\BinaryFinderTest::testDefaultFindsCat
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/bin/cat'
+'/usr/bin/cat'

/var/www/html/tests/lib/BinaryFinderTest.php:46

2) Test\BinaryFinderTest::testCustomPathFindsCat
Failed asserting that '/usr/bin/cat' matches expected false.

/var/www/html/tests/lib/BinaryFinderTest.php:70

This change removes these assumptions to make the tests pass on all systems (OK well, you still need to have cat installed).

@provokateurin
test(BinaryFinder): Make sure the test is portable between systems
e391e50 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin added this to the Nextcloud 33 milestone Sep 5, 2025
@provokateurin provokateurin requested a review from a team as a code owner September 5, 2025 07:50
@provokateurin provokateurin requested review from Altahrim and nfebe and removed request for a team September 5, 2025 07:50
@provokateurin provokateurin merged commit acb26a4 into master Sep 5, 2025
214 of 221 checks passed
@provokateurin provokateurin deleted the test/binary-finder/portability branch September 5, 2025 13:09
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Oct 2, 2025
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Altahrim Altahrim Altahrim approved these changes

@kesselb kesselb kesselb approved these changes

@come-nc come-nc Awaiting requested review from come-nc

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews technical debt

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@provokateurin @Altahrim @kesselb @skjnldsv